D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart

[Nathaniel Graham]

ngraham created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  kateview's "Switch input mode" feature is currently bound to [Ctrl] + [⇧] + [V] This
  causes two problems:
  
  1. When the embedded konsolepart is visible, both it and Kate claim the same shortcu so neither works
  2. At other times, it's easily possible to accidentally enter vi mode when you mean to paste due to residual muscle memory from having pasted test in Konsole recently
  
  For these reasons, this patch changes the default shortcut to [Ctrl] + [Alt] + [V], which
  is also kind of more elegant anyway since it now uses the [Alt] key and triggers
  alternate input modes.
  
  BUG: 409978
  FIXED-INL 5.61

TEST PLAN
  1. Compile
  2. Open Kate
  3. Hit [Ctrl] + [⇧] + [V] and see that nothing happens
  4. Copy some text
  5. Open embedded Konsole and paste text with [Ctrl] + [⇧] + [V] and see that it works
  6. Hit [Ctrl] + [Alt] + [V] and see that it enters vi mode

REPOSITORY
  R39 KTextEditor

BRANCH
  remap-change-input-mode-shortcut (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22574

AFFECTED FILES
  src/view/kateview.cpp

To: ngraham
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190720/6dee9418/attachment.html>