D22308: Snippets: Make snippet shortcuts work also if the snippets tool view is minimized, by adding the QActions to the main window instead of the tool view

[Thomas Schöps]

thomassc created this revision.
Herald added a project: Kate.
Herald added a subscriber: kwrite-devel.
thomassc requested review of this revision.

REVISION SUMMARY
  The keyboard shortcut for snippets did not work while the snippets tool view was minimized. This seems to be because the snippet QActions must be added to a visible(?) widget to be considered. Thus, this change makes the snippets plugin add its actions to the main window instead of its tool view such that they remain active when the snippets tool view is minimized to the side.

TEST PLAN
  I tested it manually. Note for testing: There seems to be another bug that sometimes prevents the shortcuts for new snippets from working (a restart of the application should make them work). I think that this is unrelated to this change and will try to address it next.

REPOSITORY
  R40 Kate

BRANCH
  snippet_shortcuts_with_minimized_tool_view

REVISION DETAIL
  https://phabricator.kde.org/D22308

AFFECTED FILES
  addons/snippets/katesnippets.cpp
  addons/snippets/snippetview.cpp
  addons/snippets/snippetview.h

To: thomassc
Cc: kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190707/bc46b902/attachment.html>