D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

[Dominik Haumann]

dhaumann added a comment.


  Unfortunately, the change in the .ui file introduced bug https://bugs.kde.org/show_bug.cgi?id=403422
  
  The minimum and maximum were set from 1...5 to -1...-1. Will post a followup patch.
  
  @loh.tar Did you remove and add the slider manually again, or how did that happen?
  
  PS: It seems we did a bad review job here ;)

INLINE COMMENTS

> textareaappearanceconfigwidget.ui:187-197
> +           <property name="minimum">
> +            <number>-1</number>
> +           </property>
> +           <property name="maximum">
> +            <number>-1</number>
> +           </property>
> +           <property name="singleStep">

This introduced bug https://bugs.kde.org/show_bug.cgi?id=403422

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17661

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190130/e43b5702/attachment-0001.html>