D18475: Add AsciiDoc support

Dominik Haumann noreply at phabricator.kde.org
Mon Jan 28 21:41:41 GMT 2019


dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  1. I apply your patch: arc patch D18475 <https://phabricator.kde.org/D18475>
  2. Since there is a new syntax highlighting file, I do: touch data/syntax-data.qrc.in
  3. I switch to the build directory, type make -j4 install
  4. I run the tests, some fail, since the reference of your test file is missing
  5. In the build folder, I run: ./autotests/update-reference-data.sh
  6. Now git status tells me there are several untracked files:
    - autotests/folding/asciidoc.adoc.fold
    - autotests/html/asciidoc.adoc.html
    - autotests/reference/asciidoc.adoc.ref
  7. In the source folder, I git add all these files, then commit
  8. Finally, I call: arc diff to land your patch

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18475

To: andreasgr, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, nibags, kwrite-devel, kde-frameworks-devel, #framework_syntax_highlighting, bmortimer, hase, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190128/3a76e6eb/attachment.html>


More information about the KWrite-Devel mailing list