D18117: DocManager: Don't show empty popup

[Christoph Cullmann]

cullmann added a comment.


  In D18117#397329 <https://phabricator.kde.org/D18117#397329>, @loh.tar wrote:
  
  > - if we just keep the code in ktexteditor as is
  > - we should just set openSuccess to false if we have an doc->openingError() and the document is empty
  >
  >   Um, I think that are two differend suggestions. So, well, yes, without to change the logic in D18116 <https://phabricator.kde.org/D18116> (but still apply that to remove unneded text) it work as needed. On the other hand is it that way not "full right", for me is some overlenght or encoding warning not an "open error".
  
  
  I could live with not "full right". We would get rid of the annoying popup and still have enough indication of issues in my opinion.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D18117

To: loh.tar, #kate, cullmann, dhaumann
Cc: kwrite-devel, #kate, hase, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190121/ef6c81c4/attachment.html>