D18164: Review KateGotoBar

[Christoph Cullmann]

cullmann added a comment.


  I would disconnect the textChanged in ::closed() to avoid having updates there even if the bar is hidden again (and reconnect on show).
  
  Otherwise I think this is ready to go in.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18164

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190116/74d6cf23/attachment.html>