D18164: Review KateGotoBar
noreply at phabricator.kde.org
Wed Jan 16 16:57:41 GMT 2019
cullmann added a comment.
I would disconnect the textChanged in ::closed() to avoid having updates there even if the bar is hidden again (and reconnect on show).
Otherwise I think this is ready to go in.
To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel