D17599: Confirm closing muliple tabs.
noreply at phabricator.kde.org
Tue Jan 15 23:06:54 GMT 2019
ngraham added a comment.
In D17599#392112 <https://phabricator.kde.org/D17599#392112>, @dhaumann wrote:
> The thing is: if you have multiple windows, closing a window does NOT close the document. That's why windows or the tabs are not a good measure for this question. The currently proposed implementation only asks, if you'd really close documents which is the same as closing the application.
> @emateli: I don't see how this functionality could be upstreamed and shared: it's more or less a single if statement already.
I think the advantage to upstreaming would be less about removing code duplication and more about harmonizing the text and appearance.
To: shubham, dhaumann, #kate, sars, cullmann
Cc: emateli, mwolff, ngraham, pino, kwrite-devel, hase, michaelh, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel