D17599: Confirm closing muliple tabs.

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> katemainwindow.cpp:1200
> +    const bool documentCount = KateApp::self()->documentManager()->documentList().count() > 1;
> +    const bool windowCount = KateApp::self()->mainWindowsCount() == 1;
> +    const bool askConfirmation = closedByUser && documentCount && windowCount;

Strictly speaking, 'bool documentCount' implies this is a number, but it's a bool.

Better is:

  bool multipleDocumnetsOpen = ...
  bool isLastWindow = ...

Could you adapt again?

> katemainwindow.cpp:1206
> +                     QIcon::fromTheme(QStringLiteral("application-exit")));
> +        KGuiItem no(i18n("C&lose Current Tab"), QIcon::fromTheme(QStringLiteral("tab-close")));
> +

I would have expected "Quit Kate" and "Cancel" instead of "Close Current Tab". Any opinions?

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D17599

To: shubham, dhaumann, #kate, sars, cullmann
Cc: emateli, mwolff, ngraham, pino, kwrite-devel, hase, michaelh, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190115/02a5ab34/attachment-0001.html>