D17949: ViewPrivate: Make applyWordWrap() more comfortable

loh tar noreply at phabricator.kde.org
Tue Jan 15 15:08:25 GMT 2019

loh.tar added subscribers: cullmann, dhaumann.
loh.tar added a comment.

  > please add proper tests for this functionality
  No idea how
  Because  there are a couple of bug reports where often the response was like "No, can't be done" need this a closer look from @dhaumann and @cullmann


> mwolff wrote in kateview.cpp:2355
> store in a std::unique_ptr and remove the manual `delete` further down below

fine, will do it

> mwolff wrote in kateview.cpp:2359
> bool shouldWrap = true;

I dislike that. I hope someone else like my goto way

  R39 KTextEditor


To: loh.tar, #ktexteditor, mwolff
Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190115/671192ff/attachment-0001.html>

More information about the KWrite-Devel mailing list