D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines
Milian Wolff
noreply at phabricator.kde.org
Tue Jan 15 13:38:50 GMT 2019
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
can you please rephrase the title of this review to make it understandable? "Remove all" - what do you remove? All what?
Also, can you please add tests for the feature you are adding, this also acts as documentation on what this patch actually does
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17128
To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: mwolff, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, head7, kfunk, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190115/d1da8cb3/attachment.html>
More information about the KWrite-Devel
mailing list