D17599: Confirm closing muliple tabs.
noreply at phabricator.kde.org
Sat Jan 12 19:40:43 GMT 2019
emateli added a comment.
@dhaumann It's not about the lines of code but about making the dialog consistent in all the applications in a way that one cannot get it wrong. You can notice that the title, text, icons, confirmation are all different in each of them even though the dialog itself is trivial to implement. Okuar goes the extra step and even inverts the check box action. Even this patch, which is designed after the Dolphin implementation gets the title wrong.
Anyhow, sorry about hijacking this patch with this slightly off-topic discussion about the frameworks.
To: shubham, dhaumann, #kate, sars
Cc: emateli, mwolff, ngraham, pino, kwrite-devel, hase, michaelh, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel