D18163: KateRenderer: when printing initially set the color scheme to Printing

Ahmad Samir noreply at phabricator.kde.org
Thu Jan 10 18:02:23 GMT 2019


ahmadsamir created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Otherwise the print preview dialog somehow gets the text color from the
  current default color scheme; also the user can't change the color scheme
  either from the print preview dialog or the "print" dialog launched from
  the preview dialog. All in all, this seems like a safe default.
  
  BUG: 391678
  FIXED-IN: 5.55.0

TEST PLAN
  - Change the default color scheme in kate to a dark one, e.g. Breeze dark
  - Open the print preview dialog, note that the text color is the one used in the breeze dark scheme, but the background color is still white
  
  Apply the diff, the print preview dialog will be using the Printing color scheme
  as expected.

REPOSITORY
  R39 KTextEditor

BRANCH
  print-preview-text-color

REVISION DETAIL
  https://phabricator.kde.org/D18163

AFFECTED FILES
  src/render/katerenderer.cpp

To: ahmadsamir
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190110/c60a412f/attachment.html>


More information about the KWrite-Devel mailing list