D17984: Fix emmet script by using HEX instead of OCT numbers in strings

Dominik Haumann noreply at phabricator.kde.org
Sat Jan 5 10:46:16 GMT 2019


dhaumann created this revision.
dhaumann added reviewers: carewolf, loh.tar.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  This is a follow-up commit to D17970 <https://phabricator.kde.org/D17970>, which did not yet fix it correctly.
  The fix now is to use HEX notation instead of OCTAL notation, since
  the OCTAL notation seems to not be supported by QML/V4 (which is likely
  a bug).
  
  BUG: 386151

TEST PLAN
  Scripts in Tools > Scripts > Emmet work

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-emmet

REVISION DETAIL
  https://phabricator.kde.org/D17984

AFFECTED FILES
  src/script/data/libraries/emmet/lib.js

To: dhaumann, carewolf, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190105/377baa21/attachment.html>


More information about the KWrite-Devel mailing list