D17891: WML: fix infinite loop in contexts switch & only highlight tags with valid names
noreply at phabricator.kde.org
Tue Jan 1 11:13:09 GMT 2019
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Good patch. More improvements are of course welcome :)
Minor comment: we prefer to delete commented code, usually commented code is more confusing than helpful.
Other comment: kateversion still says 2.3. Maybe it's time for an overhaul to use new default styles and raise kateversion to 5.0?
R216 Syntax Highlighting
To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel