D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713
René J.V. Bertin
noreply at phabricator.kde.org
Thu Feb 28 21:04:08 GMT 2019
rjvbb added a comment.
> Next Frameworks Tag is on Saturday, 2nd, i.e. in 2 days. Revert, or give it a try?
TBH I didn't notice any issues with the before code and am pretty certain I couldn't do better. FWIW I noticed that Scribus (1.5.5) filters out pure emoji fonts, from what I understand because they lack information needed for proper scaling. That probably explains why lines holding these glyphs are lower despite the fact that the glyphs are taller than the text.
The summary of this diff reads a bit as if it doesn't noticeably improve behaviour so my vote would be on reverting.
To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel