D18793: Handle text completion with block selection mode
noreply at phabricator.kde.org
Tue Feb 26 18:47:41 GMT 2019
ahmadsamir added a comment.
I changed the diff to make replaceText handle inserting the word completion text.
Is this a new behaviour? it exactly matches what users expect when they type something in block selection mode.
Also why would this be opt-in? if you type something in block selection is get replicated on all lines, so it follows that word completion should do the same thing...
Also note that the completion-with-remove-tail bits will have to stay in executeCompletion code, because we iterate over each line to find the tail, there won't be a removeText/replaceText that fits all the tails...
As for a unit test, I'll look into that as I haven't written one before.
To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, mwolff
Cc: mwolff, kde-frameworks-devel, kwrite-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel