D19215: Install DefinitionDownloader header

[Dominik Haumann]

dhaumann added a comment.


  I also do not see an issue with this.
  
  But I would like to add some background info that may be interesting: Downloading the syntax highlighting files will download all files, and not just the ones that changed etc. This by itself is fine, since it guarantees consistency with highlighting files that include each other with the IncludeRules rule. However, with downloading you'll get almost 300 .xml files that need to be checked for version info etc... That may be slow (and in fact one of the reasons why we compile in the files as Qt resource). That said, if you open a file that uses KSyntaxHighlighting, you may experience several hundred milliseconds of delay when the Repository instance is created.
  
  I am just adding this as a "you should know what you are doing" info, since you probably want to avoid instanciating a Repository by default on application startup, since then Qt Creator would startup slower.
  
  Besides that, no issues from my side, of course :-)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19215

To: davschul, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190224/5b456510/attachment.html>