D18997: Add functions returning all definitions for a mimetype or file name

Dominik Haumann noreply at phabricator.kde.org
Thu Feb 14 13:00:11 GMT 2019

dhaumann added inline comments.


> repository.h:176
> +     */
> +    QVector<Definition> definitionsForFileName(const QString &fileName) const;
> +

As I understand, this currently is unsorted. Wouldn't it make sense to sort the returned vector by priority?

This information is also missing currently in the API documentation: I had to read the code to understand whether the Definitions in the QVector are sorted or not. Same for definitionsForMimeType().

Any comments?

  R216 Syntax Highlighting


To: davschul, vkrause, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190214/c4148a22/attachment.html>

More information about the KWrite-Devel mailing list