D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

[Matthias Gerstner]

mgerstner created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
mgerstner requested review of this revision.

REVISION SUMMARY
  This change breaks up the rather large `TextBuffer::save()` into separate
  functions. Most notably the privileged code path that requires a D-Bus
  helper invocation is now better separated from the unprivileged local
  code path.
  
  This change also introduces a small change in behaviour: If file open
  failed for other reasons than lacking permissions the invocation of the
  D-Bus helper is skipped, since there is no hope of the helper helping us
  in this case.
  
  This is preparatory work for further security related improvements
  of the katetextbuffer privilege escalation handling.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19001

AFFECTED FILES
  src/buffer/katetextbuffer.cpp
  src/buffer/katetextbuffer.h

To: mgerstner
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190214/d67c3463/attachment.html>