D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths
noreply at phabricator.kde.org
Thu Feb 14 12:12:28 GMT 2019
mgerstner created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
mgerstner requested review of this revision.
This change breaks up the rather large `TextBuffer::save()` into separate
functions. Most notably the privileged code path that requires a D-Bus
helper invocation is now better separated from the unprivileged local
This change also introduces a small change in behaviour: If file open
failed for other reasons than lacking permissions the invocation of the
D-Bus helper is skipped, since there is no hope of the helper helping us
in this case.
This is preparatory work for further security related improvements
of the katetextbuffer privilege escalation handling.
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel