D18996: Fix building with namespaced Qt

David Schulz noreply at phabricator.kde.org
Thu Feb 14 07:00:41 GMT 2019


davschul added inline comments.

INLINE COMMENTS

> CMakeLists.txt:62
>  set_property(TARGET SyntaxHighlightingData PROPERTY POSITION_INDEPENDENT_CODE 1)
> +target_link_libraries(SyntaxHighlightingData PRIVATE Qt5::Core)

This seems like an overkill, but I'm new to CMAKE and it seems that this was the only way to get the -DQT_NAMESPACE= option added to the compiler command for the qrc_syntax-data.cpp and qrc_theme-data.cpp. Is there a simpler solution to achieve this?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18996

To: davschul, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, bmortimer, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190214/81a7701e/attachment-0001.html>


More information about the KWrite-Devel mailing list