D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag

Christoph Cullmann noreply at phabricator.kde.org
Tue Feb 12 19:29:13 GMT 2019

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.

  I think this is a useful addition, the license is ok, there is a test case and no old tests regress.
  I am not sure how good the coverage for the generated highlightings is, but at least no obvious issues.
  Thanks for the contribution.
  Btw., if you have more insight about the quality of the tests for the generated hl files and can improve that, a extra patch with more autotests is appreciated.
  But maybe the coverage is already good ;=)
  +1 for no hard-coded colors ;=)

  R216 Syntax Highlighting



To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190212/275198d8/attachment.html>

More information about the KWrite-Devel mailing list