D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

Shubham noreply at phabricator.kde.org
Thu Feb 7 03:01:21 GMT 2019

shubham added a comment.

  @dhaumann I don't think using switch when there is only a single case good thought


> sars wrote in kateviewinternal.cpp:2702
> does this even compile on OSX? Why did you change this?

I can't tell, I don't have one. Btw Q_OS_OSX  is deprecated.

> sars wrote in kateviewinternal.cpp:2718
> Where did e->accept() / e->ignore() go? There is a reason they are there...

By mistake i removed those after seeing their presence in switch, I will add those.

  R39 KTextEditor


To: shubham, cullmann
Cc: dhaumann, sars, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190207/5f79cbe3/attachment.html>

More information about the KWrite-Devel mailing list