D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

Kåre Särs noreply at phabricator.kde.org
Wed Feb 6 21:12:59 GMT 2019


sars added inline comments.

INLINE COMMENTS

> kateviewinternal.cpp:2702
>          // Move cursor to end (or beginning) of selected word
> +#ifndef Q_OS_MACOS
>          if (view()->selection()) {

does this even compile on OSX? Why did you change this?

> kateviewinternal.cpp:2718
> -
> -        e->accept();
> -        break;

Where did e->accept() / e->ignore() go? There is a reason they are there...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18788

To: shubham, cullmann
Cc: sars, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190206/e2a6a3c6/attachment.html>


More information about the KWrite-Devel mailing list