D18734: Update octave.xml to Octave 4.2.0

Nikita Sirgienko noreply at phabricator.kde.org
Tue Feb 5 16:33:10 GMT 2019


sirgienko added inline comments.

INLINE COMMENTS

> octave.xml:2745
> +        <WordDetect context="#stay" attribute="Keyword" String="end_try_catch" endRegion="Try" />
>          <!-- Catchall end keyword -->
> +        <WordDetect context="#stay" attribute="Keyword" String="end" endRegion="block" />

Could one word (`end`) be in several region?
Because, in Octave, you could end `if` statement by `endif` or just `end`.
In this variant, this syntax supported, but correct implementation also allow wrong Octave sytnax, like ending `while` via `endfor` (because we are using one region for them in code above).

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190205/33e3c6f2/attachment-0001.html>


More information about the KWrite-Devel mailing list