D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  When `CMAKE_CURRENT_SOURCE_DIR` and `CMAKE_CURRENT_BINARY_DIR` are the same directory, the "data/generators/generate-php.pl" script creates the `*-php.xml` files in "data/syntax/", therefore, adding them in `defs` causes them to be loaded twice and warnings of duplicate contexts are shown when compiling:
  
    [  8%] Generating index.katesyntax
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Start"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "FindHTML"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "FindEntityRefs"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "FindPEntityRefs"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "FindAttributes"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "FindDTDRules"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Comment"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "CDATA"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "PI"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Doctype"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Doctype Internal Subset"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Doctype Markupdecl"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Doctype Markupdecl DQ"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Doctype Markupdecl SQ"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "El Open"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "El Close"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "El Close 2"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "El Close 3"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "CSS"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "CSS content"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "JS"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "JS content"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "JS comment close"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Value"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Value NQ"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Value DQ"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Value SQ"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "FindPHP"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Base"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FindSelector"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FindFunctions"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FindValues"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Annotation"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FindUnits"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FindStrings"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FindComments"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Error"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "IsComments"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "SelectAtRule"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "@keyframes"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Within- at keyframes"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "@viewport"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Within- at viewport"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "@font-face"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Within- at font-face"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "@page"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "SelectorPseudo- at page"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Within- at page"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "IsProperty"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "NestedAtRule"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "NestedBase"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "AtRule"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "UnknownAtRule"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "AtRuleValue"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "SelectorAttr"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "SelectorAttrValue"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "SelectorPseudo"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "SelectorPseudoElements"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "SelectorPseudoValueSelector"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "SelectorPseudoValueCloseSelector"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "SelectorPseudoValue"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "SelectorPseudoValueClose"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Comment"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "RuleSet"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Rule"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "IsVariable"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "RuleParameters"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Function"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FunctionVar"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FunctionCalc"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "NestedCalc"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Calc"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FunctionUrl"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "UrlValue"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FunctionParameters"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "StringDQ"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "StringSQ"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "InsideString"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FindPHP"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Shebang"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Shebang Line"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Normal"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Object Member"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "NoRegExp"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Conditional Expression"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Object"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "FindStrings"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "String"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "String SQ"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Escape"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Character Escape"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Template"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "RawTemplate"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Substitution"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "FindComments"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Comment"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Multi/inline Comment"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Regular Expression"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "Regular Expression Character Class"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "(regex caret first check)"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "(charclass caret first check)"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "region_marker"
    "/home/nibaldo/test/syntax-highlighting/data/syntax/javascript-php.xml" Duplicate context: "FindPHP"
    [  9%] Generating qrc_theme-data.cpp
    [ 10%] Generating qrc_syntax-data.cpp
    /home/nibaldo/test/syntax-highlighting/data/syntax-data.qrc: Warning: potential duplicate alias detected: 'html-php.xml'
    /home/nibaldo/test/syntax-highlighting/data/syntax-data.qrc: Warning: potential duplicate alias detected: 'css-php.xml'
    /home/nibaldo/test/syntax-highlighting/data/syntax-data.qrc: Warning: potential duplicate alias detected: 'javascript-php.xml'

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  data-cmakelists

REVISION DETAIL
  https://phabricator.kde.org/D18746

AFFECTED FILES
  data/CMakeLists.txt

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190205/f3a51896/attachment-0001.html>