D18516: Fix end of folding region in rules with lookAhead=true

Christoph Cullmann noreply at phabricator.kde.org
Sat Feb 2 15:15:11 GMT 2019


cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think that lookAhead rules don't publish their length sounds like a sane improvement.
  
  All in all, I think the folding still has some general issues in how we handle it.
  
  e.g. I have ATM "interesting" highlighted areas for the folding of doxygen comments.
  
  I don't think we need to have an extra bool, one might later internally handle it differently with extra attributes in the hl files, like a lookAheadEndRegion as proposed, if we really don't like the general change.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-region-lookahead

REVISION DETAIL
  https://phabricator.kde.org/D18516

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann
Cc: andreasgr, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190202/a84d7d3e/attachment.html>


More information about the KWrite-Devel mailing list