D23515: Format class: add functions to know if XML files set style attributes
noreply at phabricator.kde.org
Fri Aug 30 17:19:57 BST 2019
nibags added a comment.
I also like `hasXXOverride()`.
In the case of **bold**, **italic**, **underline** and **strikeout**, functions such as `hasXXOverride()` are needed, since they are boolean values that can be turned off. But for the case **color**, **selectedColor**, **backgroundColor** and **selectedBackgroundColor**, do you think it's also necessary?
Because I think it's better not to add those functions; with the already existing functions `hasTextColor(Theme)` and `hasBackgroundColor(Theme)` is enough.
R216 Syntax Highlighting
To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel