D23515: Format class: add functions to know if XML files set style attributes
noreply at phabricator.kde.org
Thu Aug 29 23:01:10 BST 2019
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
What I currently dislike is that `definitionHasXyz` implies the Definition class has something, which is not correct, since it's about whether the Format has an override. I would very much prefer: bool overridesBold, overridesItalic, overridesTextColor.
Can we agree on this?
R216 Syntax Highlighting
To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel