D23515: Format class: add functions to know if XML files set style attributes

[Dominik Haumann]

dhaumann added a comment.


  I am thinking about whether ` overwritesBold()` , ... is better than `definitionHasBold()`. Because the `Format` matches an `itemData` in xml. Or even `boldHardcoded()`.
  
  Any thoughts?
  
  PS: Another solution is to port all xml files to not use hard coded colors. That's a lot of work, though.

INLINE COMMENTS

> format.h:149
> +    /** Returns @c true if the syntax definition file specifies a value for the
> +     *  italic text attribute. If the return is @c true, this value is
> +     *  obtained by isItalic().

Better: If @p true is returned, ...

> format.h:155
> +    bool definitionHasItalic() const;
> +    /** Returns @c true if the syntax definition file specifies a value for the
> +     *  underlined text attribute. If the return is @c true, this value is

Could you add an empty line after a function such that the next doxygen block starts after the newline?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23515

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190828/c72b38c2/attachment.html>