D23500: Support for native Matlab strings
noreply at phabricator.kde.org
Tue Aug 27 17:59:58 BST 2019
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
Hi, I think it is very nice that you pickup the matlab file!
Three things I would like to have changed:
1. please move the example from the comment in the XML to autotests/input/test.m, then we can have reference results for this and see changes
2. version of the file must be increased, otherwise the updating mechanism is tricked
3. I would prefer not to have hardcoded colors if possible
R216 Syntax Highlighting
To: bbuch, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel