D23484: gcc naming conflict
noreply at phabricator.kde.org
Tue Aug 27 11:31:55 BST 2019
mickaelbo created this revision.
mickaelbo added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mickaelbo requested review of this revision.
With gcc 7.4.0 (and maybe some other versions), "major" and "minor" are set as macro and expand to "gnu_dev_major" and "gnu_dev_minor".
See: https://bugzilla.redhat.com/show_bug.cgi?id=130601 <https://bugzilla.redhat.com/show_bug.cgi?id=130601>
These strings are used in the affected file for variable naming.
The attached patch undef the gcc renaming.
A syntax-highlighting user, Jonathan, reported the issue, provided the patch and tested it after trying to compile the project when the last commit was authored by me. Thank you Jonathan.
The compilation shall not fail with gcc 7.4.0.
R216 Syntax Highlighting
To: mickaelbo, #framework_syntax_highlighting
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel