D23422: Fix: allow turn off attributes in XML highlighting files
noreply at phabricator.kde.org
Sun Aug 25 11:22:14 BST 2019
nibags created this revision.
nibags added reviewers: KTextEditor, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.
In syntax highlighting XML files, it doesn't work to turn off attributes, for example: `bold="0"`, `italic="0"` or `underline="0"`.
This is fixed, but only for KSyntaxHighlighting themes, that is, this continues to not work in "KDE" and "Vim (dark)".
To correct that it is necessary to add to the API of the `KSyntaxHighlighting::Format` class, methods such as `hasBold()`, `hasItalic()`, etc. to know if the attributes "bold", "italic", "underline" & "strikeout" are modified in the XML file (the methods `isBold(...)`, `isItalic(...)`, etc., return the combination between the syntax definition and the theme).
To: nibags, #ktexteditor, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel