D20852: Fix to show folding preview when move the mouse from bottom to top

loh tar noreply at phabricator.kde.org
Fri Apr 26 19:57:46 BST 2019


loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Without this patch happens in that case nothing. You have to leave the area
  an hover again the folding begin to trigger the popup.
  
  - Tried to simplify the code

TEST PLAN
  TODO/QUESTIONS
  
  - Increase m_delayFoldingHlTimer to 500ms just for interest, 150 is not to notice
  - The working of these timer looks to me broken. I guess the intend was to delay only the popup, or maybe always, but currently it looks somehow pointless.
  - With this new value you have at least a flicker protection when you try to reach the areas behind the folding area. Perhaps is that the only intend(?)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20852

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190426/d77308c7/attachment.html>


More information about the KWrite-Devel mailing list