D20722: ViewSpace: Don't ASSERT, just check for valid doc to remove from tab

[Christoph Cullmann]

cullmann added a reviewer: dhaumann.
cullmann added a comment.


  Hmm, perhaps the restore view stuff does create the issues:
  
    // restore Document lru list so that all tabs from the last session reappear
     const QStringList lruList = group.readEntry("Documents", QStringList());
     for (int i = 0; i < lruList.size(); ++i) {
         auto doc = KateApp::self()->documentManager()->findDocument(QUrl(lruList[i]));
         if (doc) {
             const int index = m_lruDocList.indexOf(doc);
             if (index < 0) {
                 registerDocument(doc);
                 Q_ASSERT(m_lruDocList.contains(doc));
             } else {
                 m_lruDocList.removeAt(index);
                 m_lruDocList.append(doc);
             }
         }
     }
  
  the else case with the lruDocList changes might mess up some lru => tab order, or?

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D20722

To: loh.tar, #kate, dhaumann
Cc: cullmann, kwrite-devel, #kate, domson, michaelh, ngraham, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190422/9884f8f7/attachment.html>