D20606: Add action to toggle folding of child ranges

Christoph Cullmann noreply at phabricator.kde.org
Fri Apr 19 12:31:08 BST 2019

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.

  Given we have no actions and some more proper documentation, I am in favor of this.
  I would remove the two asserts here:
  Q_ASSERT(startLine >= 0);
    Q_ASSERT(startLine < lines());
    if (startLine < 0 || startLine >= lines()) {
        return KTextEditor::Range::invalid();
  I think range checking + invalid range as result is good enough.

  R39 KTextEditor


To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190419/a42f28bb/attachment.html>

More information about the KWrite-Devel mailing list