D20467: Allow to close a document whose file was deleted on disk
Méven Car
noreply at phabricator.kde.org
Fri Apr 12 09:49:23 BST 2019
meven requested review of this revision.
meven added a comment.
In D20467#448537 <https://phabricator.kde.org/D20467#448537>, @cullmann wrote:
> One could try to first do a closeUrl and just do the closeDocumentInApplication() in addition afterwards.
Great suggestion !
I have tested the current code with success in KWrite and Kate.
I have disabled the data loss confirmation as I intended using a trick with m_fileChangedDialogsActivated.
I am not too fond of this solution, so I would happily use feedback.
Maybe add a boolean parameter to closeUrl like closeUrl(prompt = true) ?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D20467
To: meven, cullmann, #kate, #frameworks, dhaumann
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, bruns, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190412/d82ca82d/attachment.html>
More information about the KWrite-Devel
mailing list