D20467: Allow to close a document whose file was deleted on disk
noreply at phabricator.kde.org
Fri Apr 12 05:49:13 BST 2019
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good to me.
> + m_message->addAction(closeFile, false);
> + connect(closeFile, SIGNAL(triggered()), this, SIGNAL(closeTriggered()));
Could you switch this to new style signal slot syntax? In a separate review request would also be fine.
To: meven, cullmann, #kate, #frameworks, dhaumann
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, bruns, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel