D20343: fix handling of sub modules in git rely on ls-files --recurse-submodules, there since end of 2016

loh tar noreply at phabricator.kde.org
Sun Apr 7 14:15:17 BST 2019


loh.tar accepted this revision.
loh.tar added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kateprojectworker.cpp:251
> +    /**
> +     * query files via ls-files, make them absolute afterwards
> +     */

- query files via "git ls-files" and make...
- query files from git and make...

> kateprojectworker.cpp:272
> +     * use --recurse-submodules, there since git 2.11 (released 2016)
> +     * our own submodules handling code leads to file duplicates
> +     */

This hint may better placed in the commit log. The submodule handling is gone now, right? 
A note, why --recurse-submodules is there, is of cause nice

REPOSITORY
  R40 Kate

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20343

To: cullmann, dhaumann, #kate, loh.tar
Cc: kwrite-devel, gennad, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190407/bc9b29e1/attachment-0001.html>


More information about the KWrite-Devel mailing list