D20264: Add test for "Auto Reload Document" option
loh tar
noreply at phabricator.kde.org
Sat Apr 6 17:27:59 BST 2019
loh.tar updated this revision to Diff 55576.
loh.tar edited the summary of this revision.
loh.tar added a comment.
- Enhance the test by checks for proper cursor position
While adding your tiny change, it pointed out, that the test was not correct regarding needed waiting times. Pls compare new/old comments about the delays :-/ Any idea to the magic value?
I noticed..
- that slotDelayedHandleModOnHd is still called/processed. I'm not sure if that's OK
- KateViewInternal::updateView is very often called and so doc()->delayAutoReload() too. The intend was to block the reload while scrolling around. Perhaps could that blocking somewhere else better placed
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20264?vs=55468&id=55576
REVISION DETAIL
https://phabricator.kde.org/D20264
AFFECTED FILES
autotests/src/katedocument_test.cpp
autotests/src/katedocument_test.h
src/document/katedocument.cpp
To: loh.tar, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190406/4c18dc4d/attachment.html>
More information about the KWrite-Devel
mailing list