D15836: Endless state transition guard
noreply at phabricator.kde.org
Sat Sep 29 16:37:37 BST 2018
cullmann created this revision.
cullmann added reviewers: dhaumann, vkrause, nibags.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.
This e.g. catches the "hang" people did see before the fix in https://phabricator.kde.org/D15773
Its a simple good old "endless loop counter" that aborts after too many transitions.
IMHO more than a few without any progress at the text offset make no sense, therefore the hard limit of 1024 should be reasonable
I tried the examples attached for https://phabricator.kde.org/D15773, with my fix, I get just
Endless state transitions, aborting highlighting of line.
as debug output but no longer any hang.
(but yes, the highlighting of some lines is messed up, which IMHO is ok, much better than a hard hang of the application
R216 Syntax Highlighting
To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel