D15804: Fix Duplicates on Quick Open File

Tomaz Canabrava noreply at phabricator.kde.org
Fri Sep 28 13:34:47 BST 2018

tcanabrava added a comment.

  In D15804#333212 <https://phabricator.kde.org/D15804#333212>, @cullmann wrote:
  > We have some bugs complaining about the quick open speed, like https://bugs.kde.org/show_bug.cgi?id=399151
  > Therefore I was a bit concerned ;=)
  > Perhaps somebody else could take a look, too.
  >  I would be ok with this changes.
  I belive that this will fix some of the slowness in cornercases.
  I tested in *huge* directories (as I told you, 70.000 files), I can try with bigger ones if you are interested.
  The other thing we can do is to actually change this to a QTableModel instead of manually creating QStandardItems.
  The biggest source tree that I have is my
  > btw. linecount += 1; is easier to read written as either ++linecount or linecount++; Not that it matters for the compiler.
  We disagree in the last bit (it's clear that's incrementing by one, while '++' makes no sense in tons of languages), but if you want I can remove.

  R40 Kate


To: tcanabrava, cullmann, brauch, neundorf
Cc: anthonyfieroni, kwrite-devel, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180928/ed3d044a/attachment.html>

More information about the KWrite-Devel mailing list