D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes
noreply at phabricator.kde.org
Wed Sep 26 15:45:24 BST 2018
nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.
After upgrading to KDE Frameworks 5.50.0, Kate crashes when detecting open AppArmor rules (the AppArmor rules are closed with a comma. If the user doesn't write a comma, the syntax highlighting underlines the statement of the following rule. This is defined in the `_end_rule_irnc` context of the XML file.)
The problem occurs with the use of `#pop#pop!context` in the `_end_rule_irnc` context, only in KF5.50. However, apparently, this only happens in very large files. For example, this problem occurs to me when I open the new test file, updated in this diff. However, I do not know the exact cause of this error...
On line 184 of the test file, I put some examples of open AppArmor rules.
Also, some changes are made in the colors so that the highlighting looks better in the last update of Solarized schemes.
R216 Syntax Highlighting
To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel