D15556: Fix: Email highlighting for unclosed parenthesis in Subject header
Dominik Haumann
noreply at phabricator.kde.org
Sun Sep 16 19:05:14 BST 2018
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.
REVISION SUMMARY
Unfortunately, the "Subject:" header needs to be treated independently
of the other headers, since it may contain arbitrary text such as paranthesis
that is not a comment or similar. The fix is to add another context without
the comment highlighting.
BUG: 398717
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
fix-email-subject (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15556
AFFECTED FILES
autotests/folding/test.eml.fold
autotests/html/test.eml.html
autotests/input/test.eml
autotests/reference/test.eml.ref
data/syntax/email.xml
To: dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180916/37e4ebc9/attachment.html>
More information about the KWrite-Devel
mailing list