D12016: [ktexteditor] much faster positionFromCursor

[Alexander Volkov]

volkov added a comment.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.


  I get the following warning from valgrind because of this change:
  
    ==3621== Conditional jump or move depends on uninitialised value(s)
    ==3621==    at 0x4FF3605: KateViewAccessible::positionFromCursor(KateViewInternal*, KTextEditor::Cursor const&) const (kateviewaccessible.h:201)
    ==3621==    by 0x4FE41CA: KateViewInternal::documentTextInserted(KTextEditor::Document*, KTextEditor::Range const&) (kateviewinternal.cpp:3830)
    ==3621==    by 0x967762A: call (qobjectdefs_impl.h:376)
    ==3621==    by 0x967762A: QMetaObject::activate(QObject*, int, int, void**) (qobject.cpp:3754)
    ==3621==    by 0x50C25E6: KTextEditor::DocumentPrivate::textInserted(KTextEditor::Document*, KTextEditor::Range const&) (moc_katedocument_6APBFLF6VF33HC.cpp:985)
    ==3621==    by 0x4F498DE: KTextEditor::DocumentPrivate::editInsertText(int, int, QString const&) (katedocument.cpp:1235)
    ==3621==    by 0x4F4DF67: KTextEditor::DocumentPrivate::insertText(KTextEditor::Cursor const&, QString const&, bool) (katedocument.cpp:780)
    ==3621==    by 0x4F51838: KTextEditor::DocumentPrivate::typeChars(KTextEditor::ViewPrivate*, QString const&) (katedocument.cpp:3024)
    ==3621==    by 0x4FE9BF4: KateViewInternal::keyPressEvent(QKeyEvent*) (kateviewinternal.cpp:2522)
    ==3621==    by 0x4FF1F12: KateViewInternal::eventFilter(QObject*, QEvent*) (kateviewinternal.cpp:2370)
    ==3621==    by 0x96493EC: QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) (qcoreapplication.cpp:1174)
    ==3621==    by 0x8284834: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
    ==3621==    by 0x828D30E: QApplication::notify(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
    ==3621==  Uninitialised value was created by a heap allocation
    ==3621==    at 0x4C2C25F: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==3621==    by 0x4FE3EF0: accessibleInterfaceFactory(QString const&, QObject*) (kateviewaccessible.h:288)
    ==3621==    by 0x8A70D2C: QAccessible::queryAccessibleInterface(QObject*) (in /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.0)
    ==3621==    by 0x8A7172E: QAccessibleEvent::accessibleInterface() const (in /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.0)
    ==3621==    by 0x8A71BFC: QAccessible::updateAccessibility(QAccessibleEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.0)
    ==3621==    by 0x82C0A72: QWidgetPrivate::show_helper() (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
    ==3621==    by 0x82C3CC4: QWidget::setVisible(bool) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
    ==3621==    by 0x82C0957: QWidgetPrivate::showChildren(bool) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
    ==3621==    by 0x82C09DE: QWidgetPrivate::show_helper() (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
    ==3621==    by 0x82C0946: QWidgetPrivate::showChildren(bool) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
    ==3621==    by 0x82C09DE: QWidgetPrivate::show_helper() (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
    ==3621==    by 0x82C3CC4: QWidget::setVisible(bool) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12016

To: jtamate, #kate, cullmann, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, volkov, anthonyfieroni, mwolff, brauch, cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180911/4d6ccb92/attachment-0001.html>