D15358: Unit test: Check all shipped themes for completeness

Dominik Haumann noreply at phabricator.kde.org
Sat Sep 8 21:06:16 BST 2018


dhaumann created this revision.
dhaumann added reviewers: vkrause, cullmann, acrouthamel.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  The added unit test makes sure
  
  - the *.theme files in the Qt resource are valid JSON
  - contain all text styles
  - all text styles are defined with correct entires
  - all text styles at least have a text-color set
  - all text style expected bool values are valid bool values
  - all text style expected colors are valid colors
  - contain all editor colors
  - all editor colors are valid colors

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  check-themes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15358

AFFECTED FILES
  autotests/theme_test.cpp

To: dhaumann, vkrause, cullmann, acrouthamel
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180908/fbad5150/attachment.html>


More information about the KWrite-Devel mailing list