D15207: precompute attribute format for context & rules

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Hmm, tests are unstable :/
  I did run them here now X times, they are stable. Perhaps depending on which highlightings got parsed in which order.
  Why should then the id's be equal for different definitions?
  
  e.g.
  
  QDEBUG : TestHighlighterTest::testHighlight(test.py) Using syntax "Python"
  
  - "/home/jenkins/workspace/Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9/autotests/reference/test.py.ref"	2018-09-01 16:10:03.327043830 +0000
  
  +++ "/home/jenkins/workspace/Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9/build/autotests/output/test.py.ref"	2018-09-01 16:13:08.885670252 +0000
  @@ -1,6 +1,6 @@
  -<Comment>#</Comment><Comment> comment with </Comment><Alert Level 1>ALERT</Alert Level 1><br/>
  +<Comment># comment with </Comment><Alert Level 1>ALERT</Alert Level 1><br/>
   <Normal Text></Normal Text><br/>
  -<Comment>'''</Comment><Comment> multiline</Comment><br/>
  +<Comment>''' multiline</Comment><br/>
   <Comment>    comment</Comment><br/>
   <Comment>    </Comment><Alert Level 3>###</Alert Level 3><br/>
   <Comment>    '''</Comment><br/>

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15207

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180901/1b66d00e/attachment-0001.html>