D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

[Dominik Haumann]

dhaumann added a comment.


  As I see we have the following situation
  
  - the current implementation does work reasonably well
  - just because we cannot match a theme 100% does not imply that we have to adapt our implementation (there will always be a color in theme xy that does not properly exist in KTextEditor)
  - KTextEditor does not use color themes from KSyntaxHighlighting yet, so the transition is not complete
  
  Given no action in a long time, this indeed looks like a 'reject'. Still, maybe we should reevaluate? Volunterrs? ;)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5802

To: intelfx, #kdevelop, #ktexteditor, #kate, mwolff
Cc: kossebau, cullmann, kde-frameworks-devel, brauch, dhaumann, mwolff, kwrite-devel, michaelh, ngraham, bruns, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181028/f3953542/attachment.html>