D16414: Changes to REXX syntax highlighting
noreply at phabricator.kde.org
Thu Oct 25 19:41:45 BST 2018
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
Hi, nice that you take care of fixing these issues.
Two small things that could be improved:
1. the version="2" needs to be bumped to 3
2. there should be some unit test for the highlighting, you can put some test file into autotests/input (e.g. test.rex) this will make it much easier to keep this in a OK state in the future
If you need more pointers on the testing, just ping us here, thanks!
R216 Syntax Highlighting
To: phily, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel