D16376: [tabswitcher] Fix beginRemoveRows call
David Edmundson
noreply at phabricator.kde.org
Mon Oct 22 17:05:28 BST 2018
davidedmundson created this revision.
davidedmundson added a reviewer: Kate.
Herald added a project: Kate.
Herald added a subscriber: kwrite-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
To remove one row first and last should be the same index.
This hit an assert on newer Qt.
TEST PLAN
I hit this booting up with no args with kate
restoring to split views each with one document.
From the calling code it seems to be trying to just remove one row.
It now starts. Hitting control+n, control_w does add/remove tabs respectively
REPOSITORY
R40 Kate
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16376
AFFECTED FILES
addons/tabswitcher/tabswitcherfilesmodel.cpp
To: davidedmundson, #kate
Cc: kwrite-devel, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181022/dcd98aa1/attachment-0001.html>
More information about the KWrite-Devel
mailing list