D16341: Minor cleanups of TabSwitcher plugin

Dominik Haumann noreply at phabricator.kde.org
Sun Oct 21 16:43:45 BST 2018


dhaumann marked an inline comment as done.
dhaumann added inline comments.

INLINE COMMENTS

> gregormi wrote in tstestapp.cpp:23
> I wondered why this works despite that fact that the given file does not exist. But apparently, all needed parts of the document instance are filled to be useful in this test.

This works, because if a document cannot be loaded, it will save it to disk when we call save(). But we never call save(), so everything is fine.

REPOSITORY
  R40 Kate

BRANCH
  tabswitcher-cleanups (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16341

To: dhaumann, gregormi
Cc: kwrite-devel, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181021/40a5d8cc/attachment.html>


More information about the KWrite-Devel mailing list